Disable timestamp with time zone in create, alter and insert statements#22926
Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom Jun 7, 2024
Merged
Conversation
Contributor
|
Nit - suggest edit to release note entry to include the PR number. |
hantangwangd
reviewed
Jun 5, 2024
Member
hantangwangd
left a comment
There was a problem hiding this comment.
Thanks for the fix. Change looks good to me, only one little nits.
gupteaj
reviewed
Jun 5, 2024
gupteaj
previously approved these changes
Jun 5, 2024
hantangwangd
reviewed
Jun 5, 2024
b513c81 to
9307809
Compare
Timestamp with time zone is not allowed in DDL statements because inserts fail, but tables with timestamp with time zone can be registered and queried.
dbc37bb to
d29dc9b
Compare
hantangwangd
approved these changes
Jun 6, 2024
Member
hantangwangd
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix. Please rerun the fail test.
gupteaj
approved these changes
Jun 6, 2024
tdcmeehan
approved these changes
Jun 7, 2024
Contributor
|
@wanglinsong can we backport this into 0.285, 0.286 and 0.287? |
36 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Timestamp with time zone is not allowed in DDL statements because inserts fail, but tables with timestamp with time zone can be registered and queried.
Description
Presto issue #22794
Motivation and Context
When querying an Iceberg table in AWS Glue the following error is received: 'Iceberg column type timestamptz is not supported'. This worked before Presto 0.285. It is related to #21096
Impact
Create table, alter table and insert statements having "timestamp with time zone" will return error for Iceberg tables:
'Iceberg column type timestamptz is not supported'.
But existent Iceberg tables with timestamp with time zone can be registered and queried.
Test Plan
Add a new test in IcebergDistributedSmokeTestBase
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.